-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code reorganization: Removes ocl kernel API, moves math, print into kernel_api_impl #1420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: show. |
diptorupd
force-pushed
the
technical-debt
branch
2 times, most recently
from
March 31, 2024 10:56
28fd813
to
accc208
Compare
diptorupd
force-pushed
the
technical-debt
branch
2 times, most recently
from
April 1, 2024 20:59
44d6eaf
to
b37f815
Compare
diptorupd
force-pushed
the
technical-debt
branch
2 times, most recently
from
April 3, 2024 22:45
7afba84
to
f9fdb91
Compare
diptorupd
changed the title
Shed four years worth of technical debt
Code reorganization: Removes ocl kernel API, moves math, print into kernel_api_impl
Apr 3, 2024
diptorupd
force-pushed
the
technical-debt
branch
from
April 4, 2024 14:58
f9fdb91
to
4f8bfe9
Compare
diptorupd
force-pushed
the
technical-debt
branch
from
April 4, 2024 15:34
4f8bfe9
to
574199c
Compare
diptorupd
force-pushed
the
technical-debt
branch
from
April 4, 2024 15:57
574199c
to
eb5a48b
Compare
ZzEeKkAa
approved these changes
Apr 4, 2024
github-actions bot
added a commit
that referenced
this pull request
Apr 4, 2024
Code reorganization: Removes ocl kernel API, moves math, print into kernel_api_impl f2d3080
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR sifts through the mounds of tech debt accumulated over the years and cleans up whatever possible.
Summary of changes:
Remove the legacy OCL-like kernel API implementation
It was the starting point of numba-dpex (aka numba-dppy aka numba-pydppl aka pydppl aka dppy, I forget the chronology). Now thanks to the target-specific overload-based
kernel_api_impl
all features in theocldecl
andoclimpl
modules have been cleanly implemented as a SYCL-like API and thus are no longer needed.Remove
core.types.array.Array
Has been superseded by
USMNdArray
and was no longer needed.Minor fixes to imports
Minor linter highlighted fixes.
Move
printimpl
intokernel_api_impl.spirv
Each backend for
kernel_api
should provide its ownprint
implementation that will be registered to the backend's typing and target contexts. Thus, the module belongs insidekernel_api_impl.spirv
.Move
ocl.mathimpl
andocl.mathdecl
intokernel_api_impl.spirv.math
Moves the standard lib
math
module support from top-levelocl
module intokernel_api_impl.spirv.math
and gets rid ofocl
completely. Each back end forkernel_api
has to provide its implementation of the math functions, so the code belongs inside each back end. The code itself is not very well designed and not much can be done right now.#Fixes #795