Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/dpctl slices #1425

Merged
merged 2 commits into from
Apr 3, 2024
Merged

Fix/dpctl slices #1425

merged 2 commits into from
Apr 3, 2024

Conversation

ZzEeKkAa
Copy link
Contributor

@ZzEeKkAa ZzEeKkAa commented Apr 3, 2024

Fixes: #1390

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@ZzEeKkAa ZzEeKkAa self-assigned this Apr 3, 2024
@ZzEeKkAa ZzEeKkAa marked this pull request as ready for review April 3, 2024 20:03
@ZzEeKkAa ZzEeKkAa requested a review from diptorupd April 3, 2024 20:03
diptorupd
diptorupd approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ZzEeKkAa ZzEeKkAa merged commit 6e0d9bb into main Apr 3, 2024
48 of 57 checks passed
@ZzEeKkAa ZzEeKkAa deleted the fix/dpctl_slices branch April 3, 2024 22:17
github-actions bot added a commit that referenced this pull request Apr 3, 2024
@github-actions
Merge pull request #1425 from IntelPython/fix/dpctl_slices
0dc3a3e 
Fix/dpctl slices 6e0d9bb
@coveralls
Copy link
Collaborator

Coverage Status

coverage: 84.358% (+0.04%) from 84.317%
when pulling 3956fe7 on fix/dpctl_slices
into e52b423 on main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees

@ZzEeKkAa ZzEeKkAa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Creating slices over dpctl.tensor.usm_ndarray objects inside a kernel cause failure
3 participants
@ZzEeKkAa @coveralls @diptorupd