Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove artifacts from conda/wheel packages residing in root level #1447

Merged
merged 4 commits into from
May 3, 2024

Conversation

AndresGuzman-Ballen
Copy link
Contributor

Removing files that are making their way to conda packages at root-level.

@coveralls
Copy link
Collaborator

coveralls commented May 1, 2024

Coverage Status

coverage: 86.494%. remained the same
when pulling 32fa39f on SAT-6809
into c1b8a59 on main.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented May 1, 2024

Thank you @AndresGuzman-Ballen ! It is actually wired it was added to wheel..

@AndresGuzman-Ballen
Copy link
Contributor Author

No problem! Anything else you'd like me to do before merging?

@AndresGuzman-Ballen
Copy link
Contributor Author

Friendly ping to merge this :)

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @AndresGuzman-Ballen . Thanks!

@AndresGuzman-Ballen
Copy link
Contributor Author

Woohoo!

@AndresGuzman-Ballen AndresGuzman-Ballen merged commit 50cd1c5 into main May 3, 2024
14 checks passed
@AndresGuzman-Ballen AndresGuzman-Ballen deleted the SAT-6809 branch May 3, 2024 15:29
github-actions bot added a commit that referenced this pull request May 3, 2024
Remove artifacts from conda/wheel packages residing in root level 50cd1c5
@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented May 3, 2024

@AndresGuzman-Ballen @oleksandr-pavlyk I've just checked two builds and this PR did not affect result package.

@ZzEeKkAa
Copy link
Contributor

ZzEeKkAa commented May 3, 2024

Sorry, it did. I just extract two same packages...

@ZzEeKkAa ZzEeKkAa mentioned this pull request May 6, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants