Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the flag in "subprocess.check_call" for Windows #269

Merged
merged 3 commits into from
Mar 30, 2021

Conversation

vlad-perevezentsev
Copy link
Contributor

@vlad-perevezentsev vlad-perevezentsev commented Mar 1, 2021

This PR fixes Bandit warning in building script related to subprocess.check_call(..., shell=True).

Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vlad-perevezentsev could you please investigate Windows CI fail?
I have merged main into this PR branch. It should work.
It seems that some service fails. @xaleryb could you check please?

@PokhodenkoSA
Copy link
Contributor

Need to restart CI.

Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PokhodenkoSA PokhodenkoSA merged commit 6033fb8 into IntelPython:main Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants