-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code only if function name is replaced #303
Remove dead code only if function name is replaced #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, provide test case.
@PokhodenkoSA this bug was noticed originally because this test was falling back. This PR fixes this test from falling back and offloads it through our pipeline. Should we ask the original author of that test to make sure it fails if it is falling back instead of going through our pipeline? I can always write tests and that would require setting up a partial compiler pipeline to test it, which is tedious. Please share your thoughts. |
Does it mean that test did not check that code falling back? So test was blind? |
Yes. I have updated the tests to check for falling back. |
@PokhodenkoSA @diptorupd Can you please review it? |
This PR makes sure we try to remove dead code only when we replace the Numpy function names with our own. Removing dead code regardless was failing in cases where we have multiple
prange
as mentioned in this issue. This PR should close #302.