Print traceback when DPPY lowering failed. #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reazulhoque
reviewed
May 11, 2021
Open to suggestions. Even bare minimum information is wrapped in the debug flag. |
diptorupd
force-pushed
the
fix/print_tb_when_lowering_fails
branch
from
4b28486 to
59184fd
Compare
I added the exact device filter string based off |
- Print the traceback when parfor offload fails to give
developers a better idea of what went wrong.
- Improve user-facing messages. The message now includes
the device filter string where offload was desired.
Additional message added to ask users to open issues
tickets and directions on how to generate traceback.
diptorupd
force-pushed
the
fix/print_tb_when_lowering_fails
branch
from
59184fd to
ec73ed1
Compare
|
Merging as no opposition. We can further improve the error reporting in future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when parfor lowering fails and we fall back to the default CPU lowerer for a parfor a very skimpy message is printed. The PR adds the traceback to get some more information on why and where DPPY lowering failed.