Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/upgrade_to_dpctl_0.8 #375

Merged
merged 4 commits into from
May 21, 2021
Merged

feature/upgrade_to_dpctl_0.8 #375

merged 4 commits into from
May 21, 2021

Conversation

diptorupd
Copy link
Contributor

Dpctl 0.8 changes the name of dpctl.dptensor to dpctl.tensor. This PR changes the module name dptensor everywhere in our code base. Additional changes to README, meta.yaml, and config.py.

warnings.warn(msg, UserWarning)
except:
msg = "Please install dpctl 0.7.0 or higher."
msg = "Please install dpctl 0.8.* or higher."
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA May 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file contains 5 places with dpctl version. All should be updated next time.
I propose creating function like: dpctl_required("0.8.*") which will throw exception if dpctl version does not match.

@diptorupd diptorupd merged commit f5abfe8 into main May 21, 2021
@diptorupd diptorupd deleted the feature/upgrade_to_dpctl_0.8 branch May 21, 2021 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3 - Waiting: CI dpctl Integration with dpctl
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants