Fix/dppy rt extension #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 24, 2021 21:37
- Fix the library search string for libDPCTLSyclInterface.so on linux.
Without the change the search was failing to properly load
libDPCTLSyclInterface.so after the recent addition of soversions in
dpctl 0.8.0rc1.
- Removed unused code for the function and renamed initialize_all to
load_dpctl_sycl_interface.
- Properly add the dpctl library path and include path to
setup.py for the extension. With the change we do not need
to do a dlopen for libDPCTLSyclInterface.
- Renamed the extension and moved the source under the driver module.
- Code formating changes and added license header.
reazulhoque
approved these changes
May 25, 2021
I think conda build process removes rpath. It could be the problem. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dppy_rt.cextension module stopped working with dpctl 0.8.0rc1 due to the introduction of soversion names in dpctl'slibDPCTLSyclInterface. The PR fixes the problem by properly adding the libDPCTLSyclInterface to the rpath using setup.py. Additionally, the extension itself was refactored to not usedlopenbut rather properly include dpctl C API headers.The refactored extension is renamed and moved into the driver sub-module.