Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove llvmdev from runtime dependecies #498

Merged
merged 3 commits into from
Jul 26, 2021

Conversation

reazulhoque
Copy link
Contributor

This PR updates the runtime dependencies specified in the conda recipe.

  1. Remove llvmdev as we do not use opt to generate LLVM bitcode.
  2. Introduce packaging as it is being used in numba_dppy/config.py.

@PokhodenkoSA Do we need to use packaging here or can it be accomplished somehow else?

@PokhodenkoSA
Copy link
Contributor

@reazulhoque please provide PR where it started:

  1. ... we do not use opt to generate LLVM bitcode.

From this:

  1. Introduce packaging as it is being used in numba_dppy/config.py.

As I understand llvmdev depends on packaging. So now llvmdev is not used but packaging is needed. Correct?

If yes then I think the changes are good.

@reazulhoque
Copy link
Contributor Author

@PokhodenkoSA I do not see packaging as a dependency even when we have llvmdev as a runtime dependency. Both the points are applicable to this PR.

@PokhodenkoSA PokhodenkoSA merged commit 5203bc7 into IntelPython:main Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants