Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation workflow #547

Merged
merged 6 commits into from
Sep 20, 2021
Merged

Add documentation workflow #547

merged 6 commits into from
Sep 20, 2021

Conversation

1e-to
Copy link
Contributor

@1e-to 1e-to commented Sep 14, 2021 •
edited by PokhodenkoSA
Loading

Closes #286
Closes #275

@1e-to 1e-to requested a review from PokhodenkoSA September 14, 2021 11:42
PokhodenkoSA
PokhodenkoSA approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But there are proposals for improvements.

.github/workflows/generate-docs.yml Outdated Show resolved Hide resolved
.github/workflows/generate-docs.yml Outdated Show resolved Hide resolved
.github/workflows/generate-docs.yml Outdated Show resolved Hide resolved
.github/workflows/generate-docs.yml
Comment on lines +99 to +100
- name: Add library
run: echo "OCL_ICD_FILENAMES=libintelocl.so" >> $GITHUB_ENV
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it necessary w/o tests?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is the main problem why module doesn't import

@PokhodenkoSA
Copy link
Contributor

Fix pre-commit, please.

@PokhodenkoSA
Copy link
Contributor

@1e-to, please, fix CI.

@PokhodenkoSA
Copy link
Contributor

@1e-to, internal error fixed. Please, restart CI.

@PokhodenkoSA PokhodenkoSA merged commit a460848 into IntelPython:main Sep 20, 2021
github-actions bot pushed a commit that referenced this pull request Sep 20, 2021
@PokhodenkoSA
Add documentation workflow (#547) a460848
0a19fcd
@PokhodenkoSA PokhodenkoSA mentioned this pull request Sep 25, 2021
Closed
25 tasks
@1e-to 1e-to deleted the docs_auto branch November 3, 2021 11:47
@PokhodenkoSA PokhodenkoSA mentioned this pull request Dec 3, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Assignees

@1e-to 1e-to

Labels
documentation Improvements or additions to documentation infrastructure
Projects
None yet
Milestone
0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@1e-to @PokhodenkoSA