Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable optimization level setting #62

Merged
merged 7 commits into from
Apr 28, 2021
Merged

Enable optimization level setting #62

merged 7 commits into from
Apr 28, 2021

Conversation

akharche
Copy link
Contributor

Issue #39

PokhodenkoSA
PokhodenkoSA suggested changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, merge with master.

@akharche
Copy link
Contributor Author

This PR breaks GDB support when -O0 optimization level is set

@akharche akharche added the bug Something isn't working label Dec 11, 2020
@diptorupd diptorupd mentioned this pull request Dec 11, 2020
Closed
@akharche
Copy link
Contributor Author

@reazulhoque @diptorupd If we take llvm-spirv from oneapi compiler, it solves the problem with crash on "-O0" opt level

@akharche akharche removed 1 - In Progress bug Something isn't working labels Mar 1, 2021
@akharche akharche mentioned this pull request Apr 19, 2021
Merged
PokhodenkoSA
PokhodenkoSA reviewed Apr 26, 2021
View reviewed changes
numba_dppy/codegen.py Outdated Show resolved Hide resolved
@reazulhoque
Copy link
Contributor

@PokhodenkoSA @diptorupd should we merge this?

@akharche
Copy link
Contributor Author

@reazulhoque I think, it should be merge after problem with -O0 (addr space casting) is fixed. This code will fail if user changes option NUMBA_OPT to 0

@PokhodenkoSA
Copy link
Contributor

This code will fail if user changes option NUMBA_OPT to 0

It is up to user to use any NUMBA_OPT value. This PR only provides an option to configure.
If default NUMBA_OPT value is appropriate we could merge this PR.

@akharche akharche merged commit df774e4 into main Apr 28, 2021
@akharche akharche deleted the akharche/enable_numba_opt branch April 28, 2021 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@PokhodenkoSA PokhodenkoSA PokhodenkoSA approved these changes

Assignees

@akharche akharche

Labels
None yet
Projects
None yet
Milestone
0.14.0
Development

Successfully merging this pull request may close these issues.

NUMBA_OPT value has no impact on generated IR
4 participants
@akharche @reazulhoque @PokhodenkoSA @diptorupd