Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dpctl 0.12 #669

Merged
merged 9 commits into from
Dec 9, 2021
Merged

Support dpctl 0.12 #669

merged 9 commits into from
Dec 9, 2021

Conversation

PokhodenkoSA
Copy link
Contributor

@PokhodenkoSA PokhodenkoSA commented Dec 8, 2021

  • Compatible with dpctl 0.11
  • Build with dpctl 0.11.0
  • Test with dpctl 0.11 and 0.12

@oleksandr-pavlyk
Copy link
Contributor

Please see IntelPython/dpctl#685 (comment) for another way of allowing compatibility with both 0.11 and 0.12 until 0.12 becomes commonplace and the preprocessor macros can be removed.

I even opened a PR #645 in numba-dppy to add that. @diptorupd was not in favor.

@PokhodenkoSA
Copy link
Contributor Author

PokhodenkoSA commented Dec 9, 2021

@oleksandr-pavlyk
Thanks for the solution. Applied solution from #645.

@PokhodenkoSA PokhodenkoSA merged commit ad95dd5 into main Dec 9, 2021
github-actions bot pushed a commit that referenced this pull request Dec 9, 2021
* Update dpctl 0.12
* Fix includes for dpctl 0.12
* dpctl 0.12 in environment.yml
* Keep support for dpctl 0.11
* Use __has_include
* Use 0.11*|0.12* in conda recipe
* Build with dpctl 0.11.0
* Test with different dpctl in public CI
* Add dpctl to conda_build_config.yml ad95dd5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dpctl Integration with dpctl enhancement New feature or request infrastructure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants