Adds more custom exception classes to numba_dpex. #798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Overall this looks good. I would probably enclose kernel names in quotes in the message too. |
diptorupd
force-pushed
the
new_exception_classes
branch
from
06d2951 to
4e5e120
Compare
Thanks @oleksandr-pavlyk. I have made the suggested changes. |
diptorupd
force-pushed
the
new_exception_classes
branch
from
4e5e120 to
eb36cc8
Compare
diptorupd
force-pushed
the
new_exception_classes
branch
from
0407e92 to
13dbe66
Compare
|
Merging based on public CI. Teamcity CI is failing due to an internal issue. |
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2022
Adds more custom exception classes to numba_dpex. 6a8ac1b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds several new custom exception classes. Most of the exceptions are not used anywhere yet. The work for raising the exceptions is ongoing as part of the refactoring of the kernel API that will be part of a different PR.