Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes the experimental parfor fallback feature. #817

Closed
wants to merge 6 commits into from

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Nov 10, 2022

  • Have you provided a meaningful PR description?
    numba_dpex provides an experimental parfor fallback feature. Any parfor node that could not be lowered using dpex fell back to the default Numba parfor lower extension and was lowered as a parallel loop nest on the CPU.

The PR removes the fallback feature. Instead, dpex now will raise an exception informing users what code could not be lowered.

The benefit of the change is to clearly indicate to users when some parallel code could not be offloaded.

Supersedes #794

  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd force-pushed the remove_parfor_fallback branch from 9661609 to 9721e1f Compare November 10, 2022 19:26
@diptorupd
Copy link
Contributor Author

After #957 and all the dpnp parfor related changes, numpy offload is now deprecated and we will just remove these features in next release.

@diptorupd diptorupd closed this Mar 6, 2023
@diptorupd diptorupd deleted the remove_parfor_fallback branch March 6, 2023 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant