Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A more consistent kernel launch parameter syntax #888

Merged
merged 6 commits into from
Jan 31, 2023
Merged

A more consistent kernel launch parameter syntax #888

merged 6 commits into from
Jan 31, 2023

Conversation

chudur-budur
Copy link
Contributor

@chudur-budur chudur-budur commented Jan 25, 2023 •
edited
Loading

Addressing issues #867 and #871. This might also fix issue #886
Also related to issues #790 and #766

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur chudur-budur marked this pull request as ready for review January 25, 2023 03:36
@chudur-budur
Getting rid of core.kernel_interface.indexers.NdRange, using core.ker…
e66c0fc 
…nel_interface.utils.Ranges instead.

Fix in docstrings
diptorupd
diptorupd reviewed Jan 25, 2023
View reviewed changes
numba_dpex/core/kernel_interface/dispatcher.py Outdated Show resolved Hide resolved
numba_dpex/core/kernel_interface/dispatcher.py Outdated Show resolved Hide resolved
numba_dpex/core/kernel_interface/dispatcher.py Show resolved Hide resolved
numba_dpex/core/kernel_interface/dispatcher.py Outdated Show resolved Hide resolved
numba_dpex/core/kernel_interface/dispatcher.py Outdated Show resolved Hide resolved
numba_dpex/core/kernel_interface/dispatcher.py Outdated Show resolved Hide resolved
numba_dpex/examples/kernel/vector_sum2D.py Outdated Show resolved Hide resolved
@chudur-budur chudur-budur force-pushed the github-871 branch 2 times, most recently from 6ee40f8 to f536bd1 Compare January 27, 2023 17:54
@chudur-budur chudur-budur mentioned this pull request Jan 27, 2023
Closed
@chudur-budur
A better implementation for the Range/NdRange class, with examples
64b81a9 
Better deprecation warnings added

Following exact sycl::range/nd_range specification for kernel lauch parameters

Default cache size is set to 128, like numba

We don't need simplefilter
@fcharras fcharras mentioned this pull request Jan 29, 2023
Closed
@diptorupd diptorupd changed the title A more consistent kernel lauch parameter syntax A more consistent kernel launch parameter syntax Jan 29, 2023
diptorupd
diptorupd approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @chudur-budur

@diptorupd diptorupd merged commit aa4eb5b into IntelPython:main Jan 31, 2023
@diptorupd diptorupd deleted the github-871 branch January 31, 2023 01:59
github-actions bot added a commit that referenced this pull request Jan 31, 2023
@github-actions
Merge pull request #888 from chudur-budur/github-871
9c8a7ca 
A more consistent kernel launch parameter syntax aa4eb5b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chudur-budur @diptorupd