Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementing dpnp.zeros() and dpnp.ones() interface #923

Merged
merged 1 commit into from
Feb 22, 2023

Conversation

chudur-budur
Copy link
Contributor

@chudur-budur chudur-budur commented Feb 20, 2023

Once completed, this PR will supercede PR #743.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur chudur-budur force-pushed the dpnp/zeros-ones branch 2 times, most recently from 9d69283 to d146f65 Compare February 22, 2023 06:40
@chudur-budur chudur-budur marked this pull request as ready for review February 22, 2023 06:44
Copy link
Contributor

@mingjie-intel mingjie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@chudur-budur chudur-budur force-pushed the dpnp/zeros-ones branch 2 times, most recently from 11de07d to 5d8b5b6 Compare February 22, 2023 18:28
@chudur-budur chudur-budur changed the title [WIP] Implementing dpnp.zeros() and dpnp.ones() interface Implementing dpnp.zeros() and dpnp.ones() interface Feb 22, 2023
overloading construct from numba, also has unit-tests.
@diptorupd diptorupd merged commit 1b948c2 into IntelPython:main Feb 22, 2023
github-actions bot added a commit that referenced this pull request Feb 22, 2023
Implementing dpnp.zeros() and dpnp.ones() interface 1b948c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants