Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced llvm_spirv from oneAPI path by dpcpp-llvm-spirv package. #979

Merged
merged 2 commits into from
Mar 28, 2023
Merged

Replaced llvm_spirv from oneAPI path by dpcpp-llvm-spirv package. #979

merged 2 commits into from
Mar 28, 2023

Conversation

mingjie-intel
Copy link
Contributor

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

Documentation preview: show.

@mingjie-intel mingjie-intel force-pushed the dpcpp_llvm_spirv_clean branch from 4d2e94d to d8b0171 Compare March 22, 2023 22:27
@github-actions
Copy link
Contributor

Documentation preview: show.

@mingjie-intel mingjie-intel force-pushed the dpcpp_llvm_spirv_clean branch from d8b0171 to a0e3ba0 Compare March 22, 2023 22:46
@github-actions
Copy link
Contributor

Documentation preview: show.

@diptorupd
Copy link
Contributor

@mingjie-intel we are using llvm-spirv inside the setup.py to pre-compile the atomic emulation. That too should be updated.

@github-actions
Copy link
Contributor

Documentation preview: show.

@diptorupd
Copy link
Contributor

diptorupd commented Mar 28, 2023 •
edited
Loading

@fcharras @ogrisel Please note this change. We introduced a new package for the dpcpp-llvm-spirv that is available in dppy/label/dev and will also be available in intel after next official oneAPI release.

numba-dpex now requires this package as a build and run dependency.

@mingjie-intel mingjie-intel force-pushed the dpcpp_llvm_spirv_clean branch from f5957ed to a0e3ba0 Compare March 28, 2023 15:01
@github-actions
Copy link
Contributor

Documentation preview: show.

@github-actions
Copy link
Contributor

Documentation preview: show.

@diptorupd diptorupd added this to the 0.20.1 milestone Mar 28, 2023
diptorupd
diptorupd approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@diptorupd diptorupd merged commit de2a895 into main Mar 28, 2023
@diptorupd diptorupd deleted the dpcpp_llvm_spirv_clean branch March 28, 2023 18:28
@github-actions
Copy link
Contributor

Documentation preview removed.

github-actions bot added a commit that referenced this pull request Mar 28, 2023
@github-actions
Merge pull request #979 from IntelPython/dpcpp_llvm_spirv_clean
c27a765 
Replaced llvm_spirv from oneAPI path by dpcpp-llvm-spirv package. de2a895
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20.1
Development

Successfully merging this pull request may close these issues.
2 participants
@mingjie-intel @diptorupd