Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjusting test_windows step to work with intel-opencl-rt=2023.1.0 #990

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Adjusting test_windows step to work with intel-opencl-rt=2023.1.0 #990

merged 1 commit into from
Apr 6, 2023

Conversation

mingjie-intel
Copy link
Contributor

In CI, shell scripts are executed with elevated priviledges, hence OpenCL loader ignores variable OCL_ICD_FILENAMES. One must set a registry value. intel-opencl-rt comes with a script to do that.

It also comes with fixed cl.cfg file, so the step to modify cl.cfg in situ is no longer needed, and in fact corrupts the file.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@mingjie-intel mingjie-intel requested a review from diptorupd as a code owner April 6, 2023 13:25
@oleksandr-pavlyk
Copy link
Contributor

You can also remove lines setting OCL_ICD_FILENAMES in test_linux job at lines 131, 137, 144, and 154 in conda-package.yml.

@mingjie-intel
Adjusting test_windows step to work with intel-opencl-rt=2023.1.0
665eb09 
In CI, shell scripts are executed with elevated priviledges, hence
OpenCL loader ignores variable OCL_ICD_FILENAMES. One must set
a registry value. intel-opencl-rt comes with a script to do that.

It also comes with fixed cl.cfg file, so the step to modify cl.cfg
in situ is no longer needed, and in fact corrupts the file.
@mingjie-intel
Copy link
Contributor Author

You can also remove lines setting OCL_ICD_FILENAMES in test_linux job at lines 131, 137, 144, and 154 in conda-package.yml.

Done. Thanks for checking.

diptorupd
diptorupd approved these changes Apr 6, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@diptorupd diptorupd merged commit c5c2962 into main Apr 6, 2023
@diptorupd diptorupd deleted the update_ocl branch April 6, 2023 19:28
github-actions bot added a commit that referenced this pull request Apr 6, 2023
@github-actions
Merge pull request #990 from IntelPython/update_ocl
84f4fd0 
Adjusting test_windows step to work with intel-opencl-rt=2023.1.0 c5c2962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@oleksandr-pavlyk oleksandr-pavlyk Awaiting requested review from oleksandr-pavlyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mingjie-intel @oleksandr-pavlyk @diptorupd