Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation for dpnp.full() #991

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Implementation for dpnp.full() #991

merged 1 commit into from
Apr 14, 2023

Conversation

chudur-budur
Copy link
Contributor

@chudur-budur chudur-budur commented Apr 6, 2023 •
edited
Loading

Implementation for dpnp.full().

This will enable calling dpnp.full() inside @dpjit functions.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@chudur-budur
Copy link
Contributor Author

chudur-budur commented Apr 6, 2023 •
edited
Loading

@diptorupd

Just look into the driver.py, it's self-contained.

The implementations are in _intrinsic.py and arrayobj.py

@chudur-budur chudur-budur force-pushed the feature/dpnp.full branch 4 times, most recently from e96fa5b to 61daa73 Compare April 12, 2023 01:53
@chudur-budur
Copy link
Contributor Author

keeping track on #254

@chudur-budur chudur-budur mentioned this pull request Apr 12, 2023
Open
20 tasks
@chudur-budur chudur-budur marked this pull request as ready for review April 12, 2023 02:00
@chudur-budur chudur-budur changed the title WIP for dpnp.full() Implementation for dpnp.full() Apr 12, 2023
@chudur-budur chudur-budur force-pushed the feature/dpnp.full branch 3 times, most recently from 66256b7 to 5da25f1 Compare April 12, 2023 15:26
@chudur-budur chudur-budur force-pushed the feature/dpnp.full branch 2 times, most recently from d2e8141 to 54ae6ee Compare April 13, 2023 23:26
diptorupd
diptorupd approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@diptorupd diptorupd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Overload implementation for dpnp.full()
751da72 
    - Adds an overload implementation for dpnp.full
    - Removes the  `like` kwarg from dpnp.empty() overload
    - Unit test cases
@diptorupd diptorupd merged commit 3ded18e into IntelPython:main Apr 14, 2023
@diptorupd diptorupd deleted the feature/dpnp.full branch April 14, 2023 17:44
github-actions bot added a commit that referenced this pull request Apr 14, 2023
@github-actions
Merge pull request #991 from chudur-budur/feature/dpnp.full
c6172b6 
Implementation for dpnp.full() 3ded18e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

@mingjie-intel mingjie-intel Awaiting requested review from mingjie-intel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chudur-budur @diptorupd