Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in the keyword argumnet when constructing a tensor. #993

Merged
merged 1 commit into from
Apr 7, 2023
Merged

Fix typo in the keyword argumnet when constructing a tensor. #993

merged 1 commit into from
Apr 7, 2023

Conversation

diptorupd
Copy link
Contributor

@diptorupd diptorupd commented Apr 7, 2023 •
edited
Loading

  • Have you provided a meaningful PR description?
    • numba-dpex's usm_ndarray type relies on dpctl.tensor to determine the default dtype for an array. In the constructor for the usm_ndarray type, there was a typo that was causing an exception in dpjit when dpnp.empty or other constructor was called without a dtype.
    • Adds a unit test case.
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd requested a review from mingjie-intel as a code owner April 7, 2023 00:07
@diptorupd diptorupd force-pushed the fix/typo_in_usm_ndarray_ctor branch from 85ff446 to 4b6e4d6 Compare April 7, 2023 00:19
@mingjie-intel
Fix typo in the keyword argumnet when constructing a tensor.
029b59a 
   - numba-dpex's usm_ndarray type relies on dpctl.tensor to
     determine the default dtype for an array. In the constructor
     for the usm_ndarray type, there was a typo that was causing
     an exception in dpjit when dpnp.empty or other constructor was
     called without a dtype.
   - Adds a unit test case.
@mingjie-intel mingjie-intel force-pushed the fix/typo_in_usm_ndarray_ctor branch from 4b6e4d6 to 029b59a Compare April 7, 2023 14:35
mingjie-intel
mingjie-intel approved these changes Apr 7, 2023
View reviewed changes
Copy link
Contributor

@mingjie-intel mingjie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one check to check shape to be a positional only argument.

@diptorupd diptorupd merged commit 5c5997e into main Apr 7, 2023
@diptorupd diptorupd deleted the fix/typo_in_usm_ndarray_ctor branch April 7, 2023 17:21
github-actions bot added a commit that referenced this pull request Apr 7, 2023
@github-actions
Merge pull request #993 from IntelPython/fix/typo_in_usm_ndarray_ctor
ffbd44f 
Fix typo in the keyword argumnet when constructing a tensor. 5c5997e
@diptorupd diptorupd mentioned this pull request Apr 7, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mingjie-intel mingjie-intel mingjie-intel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diptorupd @mingjie-intel