Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use kernel compiler for parfors as well. #996

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

diptorupd
Copy link
Contributor

  • Have you provided a meaningful PR description?
    The OffloadCompiler is deprecated and set to be removed in 0.21. Instead, we now have two separate pipelines DpjitCompiler and KernelCompiler to compile dpjit and kernel decorated functions respectively.

The PR changes the compiler.py implementation to use the KernelCompiler when compiling kernels generated as numba function IR from parfor nodes.

  • Have you added a test, reproducer or referred to an issue with a reproducer?
    Existing test cases for parfor and dpjit should not break after the change.
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@diptorupd diptorupd enabled auto-merge April 12, 2023 15:00
Copy link
Contributor

@mingjie-intel mingjie-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@diptorupd diptorupd merged commit bbf978e into main Apr 12, 2023
@diptorupd diptorupd deleted the fix/kernel_pipeline_for_parfors branch April 12, 2023 15:34
github-actions bot added a commit that referenced this pull request Apr 12, 2023
github-actions bot added a commit to chudur-budur/numba-dpex that referenced this pull request Apr 14, 2023
…ne_for_parfors

Use kernel compiler for parfors as well. bbf978e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants