You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not really surprising, but a static buffer that is too small to fit a single entire AMI response will result in a truncated response being processed.
While this could be fixed easily by simply increasing the buffer to something reasonably large, like from 4096 to 1048576 (which is what I've done in production at the moment), long term we should really be using a dynamic buffer, resizing if necessary, e.g. using realloc, in order to handle any arbitrarily long AMI response. Then we can do away with the fixed buffer altogether, and this should provide maximal resiliency.
The text was updated successfully, but these errors were encountered:
Until issue #2 is resolved, increase the buffer size from 4096
to something reasonably small (1024 * 1024) so that the chance
of AMI responses getting truncated is reduced.
Not really surprising, but a static buffer that is too small to fit a single entire AMI response will result in a truncated response being processed.
While this could be fixed easily by simply increasing the buffer to something reasonably large, like from 4096 to 1048576 (which is what I've done in production at the moment), long term we should really be using a dynamic buffer, resizing if necessary, e.g. using realloc, in order to handle any arbitrarily long AMI response. Then we can do away with the fixed buffer altogether, and this should provide maximal resiliency.
The text was updated successfully, but these errors were encountered: