Add barrier to prevent TP nccl kernel waiting. #2607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyCle1024
reviewed
Oct 16, 2024
| @@ -438,6 +440,7 @@ def _tp_model_loop( | |||
| world_size=world_size) | |||
|
|
|||
| while True: | |||
| barrier.wait() | |||
There was a problem hiding this comment.
The barrier here would cause hang if we still using old _exit_by_sending_exit_flag function on ascend.
I would add commits to remove the old exit machenism.
3 tasks
* fix exit problem on ascend platform * remove exit_flag in tp exit
lvhan028
approved these changes
Oct 18, 2024
lvhan028
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.