-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search bar doesn't return results for ASNs with fewer than three characters #893
Comments
Hi, i would like to work on this issue |
Hi @dpgiakatos would like to work on this issue |
Hi @dpgiakatos, I would like to work on this issue, |
Sir, I would like to work on this issue. |
Hi @dpgiakatos I have created a PR by making the changes please review it . |
Please read the entire issue description and the contribution guidelines. The following text exists below the screenshots section:
|
@dpgiakatos can you assign it to me so that i can work on it . |
Hi @Ronit0104123, Since you are the first to comment for addressing this issue, are not assigned to any other tasks, and have not violated the contribution guidelines for this issue, I am assigning this issue to you. Thank you! |
Yes sir, |
I would also like to work on it if possible |
I've fixed this issue in the above PR |
Describe the bug
The header's search bar only shows results after typing three or more characters. This has a problem when searching for AS numbers (ASNs) below 100, as no results are returned.
Reducing the required number of search characters could address this issue, but it may lead to performance problems due to the large database size. Instead of decreasing the character requirement, we could implement a solution where the input must start with
AS
followed by the number (e.g.,AS16
). However, this introduces a new issue: the search bar may interpret the input as an AS name rather than an AS number.To resolve this, we can check if the input starts with
AS
and is followed by a number. If so, we should search specifically for ASNs; otherwise, we can perform a general AS name search.To Reproduce
Steps to reproduce the behavior:
16
Expected behavior
We expect to receive results when searching for ASNs, regardless of their value. For example:
AS16
should return resultsAS163
should return resultsAS2497
should return resultsScreenshots
When the ASN is fewer than three characters, no results are returned:
When the ASN has three characters or more, results are returned:
Additional context
PRs from contributors who are not assigned to this issue will be automatically closed based on our contribution guidelines.
The text was updated successfully, but these errors were encountered: