Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar doesn't return results for ASNs with fewer than three characters #893

Open
dpgiakatos opened this issue Feb 5, 2025 · 11 comments
Assignees

Comments

@dpgiakatos
Copy link
Member

Describe the bug
The header's search bar only shows results after typing three or more characters. This has a problem when searching for AS numbers (ASNs) below 100, as no results are returned.

Reducing the required number of search characters could address this issue, but it may lead to performance problems due to the large database size. Instead of decreasing the character requirement, we could implement a solution where the input must start with AS followed by the number (e.g., AS16). However, this introduces a new issue: the search bar may interpret the input as an AS name rather than an AS number.

To resolve this, we can check if the input starts with AS and is followed by a number. If so, we should search specifically for ASNs; otherwise, we can perform a general AS name search.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://www.ihr.live/en
  2. Click on the search bar
  3. Enter the number 16
  4. See no results

Expected behavior
We expect to receive results when searching for ASNs, regardless of their value. For example:

  • Searching for AS16 should return results
  • Searching for AS163 should return results
  • Searching for AS2497 should return results

Screenshots
When the ASN is fewer than three characters, no results are returned:
Image

When the ASN has three characters or more, results are returned:
Image

Additional context
PRs from contributors who are not assigned to this issue will be automatically closed based on our contribution guidelines.

@Ronit0104123
Copy link
Contributor

Hi, i would like to work on this issue

@JainAarjav
Copy link

Hi @dpgiakatos would like to work on this issue

@TejasNangru
Copy link

Hi @dpgiakatos, I would like to work on this issue,
Last time i was working on some other issue thats why i was not assigned the previous issue. Now currently I am not working on any other issue.
Please assign me this issue.

@sahitya-chandra
Copy link
Contributor

Sir, I would like to work on this issue.

@JainAarjav
Copy link

Hi @dpgiakatos I have created a PR by making the changes please review it .
Thank You
#894

@dpgiakatos
Copy link
Member Author

Please read the entire issue description and the contribution guidelines. The following text exists below the screenshots section:

Additional context
PRs from contributors who are not assigned to this issue will be automatically closed based on our contribution guidelines.

@JainAarjav
Copy link

JainAarjav commented Feb 5, 2025

@dpgiakatos can you assign it to me so that i can work on it .
I am sorry i tried to contribute without being assigned to it .
Will not happen

@dpgiakatos
Copy link
Member Author

dpgiakatos commented Feb 6, 2025

Hi @Ronit0104123,

Since you are the first to comment for addressing this issue, are not assigned to any other tasks, and have not violated the contribution guidelines for this issue, I am assigning this issue to you.

Thank you!

@TejasNangru
Copy link

Yes sir,
Can you assign the issue to two of us?

@JainAarjav
Copy link

I would also like to work on it if possible

@Ronit0104123
Copy link
Contributor

I've fixed this issue in the above PR
Can you please review it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants