Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable search for ASNs below 100 #894

Closed

Conversation

JainAarjav
Copy link

@JainAarjav JainAarjav commented Feb 5, 2025

Description

This PR fixes the issue where ASNs with fewer than three characters (e.g., AS16, AS99) were not returning results due to the minimum character requirement in the search bar. The updated logic ensures:

  • If the input starts with AS followed by a number, it directly searches for ASNs.
  • Rest searches are still handled as general searches.

This fix ensures that all ASNs, regardless of their number length, return relevant results.

Related issue

Fixes #893

How Has This Been Tested?

  • Tested with inputs like AS16, AS99, AS163, and AS2497 to confirm ASN results appear.
  • Verified that searches for IP addresses, prefixes, IXPs, and other entities remain unaffected.

Screenshots (if appropriate)

Screenshot 2025-02-05 at 6 44 50 PM Screenshot 2025-02-05 at 6 45 42 PM Screenshot 2025-02-05 at 6 44 56 PM

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@dpgiakatos
Copy link
Member

Violation of contribution guidelines:
PRs from contributors who are not assigned to this issue will be automatically closed.

@dpgiakatos dpgiakatos closed this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search bar doesn't return results for ASNs with fewer than three characters
2 participants