-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge cardano-api:internal
with cardano-api
main library under Cardano.Api.Internal.*
and export required symbols
#748
base: master
Are you sure you want to change the base?
Conversation
I'm not the one who should approve, but I think this is a great change 👍 |
Besides my other remarks, nice change! |
What do you mean here? I'm able to jump between cardano-api modules just fine here: https://cardano-api.cardano.intersectmbo.org/ Can you provide examples? If linking is still broken, can you add the examples to #601 to not lose track of them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I agree with @carbolymer's comments
56d7230
to
67d826e
Compare
cardano-api:internal
with cardano-api
main library and expose requried symbols through Cardano.Api.Internal
modulecardano-api:internal
with cardano-api
main library under Cardano.Api.Internal.*
and export required symbols
It is when you write a specific link to something in a comment, by using |
Changelog
Context
Links between different components of a project in Haddock do not seem to work. Documentation in #698 link documentation from modules in
cardano-api
with modules incardano-api:internal
. For that reason, this PR combines the internal component with the main library component.How to trust this PR
Check no functionality was modified. Ensure the organisation of modules and re-exports makes sense.
I suggest considering the result of not applying the last commit (keeping the modules separated inside theCardano.Api.Internal
. Which may be clearer.Checklist