Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cl/query future pparams #1038

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Cl/query future pparams #1038

merged 1 commit into from
Feb 7, 2025

Conversation

CarlosLopezDeLara
Copy link
Contributor

Changelog

- description: |
    Add `cardano-cli conway query future-pparams`  
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

@lehins pointed out that it is missing on the CLI #1037

How to trust this PR

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@CarlosLopezDeLara CarlosLopezDeLara changed the base branch from master to smelc/adapt-to-API-pattern-removal January 29, 2025 13:08
Base automatically changed from smelc/adapt-to-API-pattern-removal to master January 29, 2025 13:20
@CarlosLopezDeLara CarlosLopezDeLara added the next-update Needs a dependency to be updated to be merged label Jan 29, 2025
@CarlosLopezDeLara CarlosLopezDeLara linked an issue Jan 29, 2025 that may be closed by this pull request
[FEATURE] - query future pparams #1039
Closed
19 tasks
@CarlosLopezDeLara CarlosLopezDeLara force-pushed the cl/query-future-pparams branch 3 times, most recently from 84d6160 to 03fd607 Compare February 4, 2025 15:02
@smelc smelc mentioned this pull request Feb 4, 2025
Closed
2 tasks
@CarlosLopezDeLara
Copy link
Contributor Author

Waiting for #1053 to resolve CI issues

@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Feb 6, 2025
Closed
19 tasks
@CarlosLopezDeLara CarlosLopezDeLara force-pushed the cl/query-future-pparams branch 2 times, most recently from 9d5814b to 6fafd88 Compare February 7, 2025 00:21
smelc
smelc approved these changes Feb 7, 2025
View reviewed changes
cardano-cli/cardano-cli.cabal Outdated Show resolved Hide resolved
@smelc smelc added this pull request to the merge queue Feb 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Feb 7, 2025
@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Feb 7, 2025
Merged via the queue into master with commit fb7c820 Feb 7, 2025
26 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the cl/query-future-pparams branch February 7, 2025 13:45
@CarlosLopezDeLara CarlosLopezDeLara mentioned this pull request Feb 7, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carbolymer carbolymer carbolymer approved these changes

@smelc smelc smelc approved these changes

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@newhoggy newhoggy Awaiting requested review from newhoggy newhoggy is a code owner

@palas palas Awaiting requested review from palas palas is a code owner

@kevinhammond kevinhammond Awaiting requested review from kevinhammond kevinhammond is a code owner

@disassembler disassembler Awaiting requested review from disassembler disassembler is a code owner

Assignees
No one assigned
Labels
next-update Needs a dependency to be updated to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] - query future pparams
4 participants
@CarlosLopezDeLara @carbolymer @smelc @Jimbo4350