Add IsString (Hash BlockHeader) #3619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the instance IsString (Hash BlockHeader) following the same pattern of many other keys in Cardano.Api. The use case is simple, being able to refer to a specific point on the chain. E.g. recentPoint :: ChainPoint recentPoint = ChainPoint (SlotNo 53427524) "5e2bde4e504a9888a4..." I am also changing the Show instance, as it seems to be the common pattern.
andreabedini
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
|
The failure on windows seems to be unrelated. It might be flaky test. It also fails on a completely unrelated PR https://github.com/input-output-hk/cardano-node/runs/5239760055?check_suite_focus=true#step:20:1223 |
Jimbo4350
approved these changes
Feb 18, 2022
|
Hi @Jimbo4350 Is there anything more I need to do here? |
|
bors r+ |
|
Build succeeded: |
8 tasks
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the instance IsString (Hash BlockHeader) following the same
pattern of many other keys in Cardano.Api. The use case is simple, being
able to refer to a specific point on the chain.
E.g.
recentPoint :: ChainPoint
recentPoint = ChainPoint (SlotNo 53427524) "5e2bde4e504a9888a4..."
I am also changing the Show instance, as it seems to be the common
pattern.