-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cardano-tracer-3712: try Windows tests. #3714
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
force-pushed
the
cardano-tracer-3712
branch
3 times, most recently
from
March 24, 2022 11:27
8bb3bb7
to
2453b22
Compare
denisshevchenko
changed the title
cardano-tracer-3712: try Windows tests for logs.
cardano-tracer-3712: try Windows tests.
Mar 24, 2022
deepfire
approved these changes
Mar 24, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
@denisshevchenko, thank you!
iohk-bors bot
added a commit
that referenced
this pull request
Mar 24, 2022
3714: cardano-tracer-3712: try Windows tests. r=deepfire a=denisshevchenko Currently, cardano-tracer still sometimes has problems with Windows tests. It should be investigated deeply and fixed. Particularly, Cardano.Tracer.Test.Logs.Tests is mostly disabled for Windows. Now, tests are restored. Co-authored-by: Denis Shevchenko <[email protected]>
Build failed: |
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Mar 24, 2022
3714: cardano-tracer-3712: try Windows tests. r=denisshevchenko a=denisshevchenko Currently, cardano-tracer still sometimes has problems with Windows tests. It should be investigated deeply and fixed. Particularly, Cardano.Tracer.Test.Logs.Tests is mostly disabled for Windows. Now, tests are restored. Co-authored-by: Denis Shevchenko <[email protected]>
Build failed: |
denisshevchenko
force-pushed
the
cardano-tracer-3712
branch
from
March 25, 2022 08:30
2453b22
to
a316846
Compare
bors r+ |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, cardano-tracer still sometimes has problems with Windows tests. It should be investigated deeply and fixed. Particularly, Cardano.Tracer.Test.Logs.Tests is mostly disabled for Windows.
Now, tests are restored.