-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reference transaction inputs to cardano-api #3804
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/cardano-api-reference-inputs
branch
from
April 20, 2022 14:47
5fde80c
to
c2307ab
Compare
Jimbo4350
requested review from
DavidEichmann,
dcoutts,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
April 20, 2022 14:48
with ReferenceTxInsScriptsInlineDatumsSupportedInEra because these three features become available at the same time. Having separate types for these features adds unnecessary boilerplate.
Jimbo4350
force-pushed
the
jordan/cardano-api-reference-inputs
branch
from
April 20, 2022 14:51
c2307ab
to
95f1d8c
Compare
Jimbo4350
requested review from
deepfire,
denisshevchenko,
jutaro,
MarcFontaine and
cleverca22
as code owners
April 20, 2022 15:11
MarcFontaine
approved these changes
Apr 20, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM tx-generator wise
newhoggy
approved these changes
Apr 20, 2022
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Apr 20, 2022
3804: Add reference transaction inputs to cardano-api r=Jimbo4350 a=Jimbo4350 3807: Fix scripts/byron-to-alonzo/mkfiles.sh script r=newhoggy a=newhoggy to work on new versions of cardano-cli which do not create an alonzo genesis file Co-authored-by: Jordan Millar <[email protected]> Co-authored-by: MarcFontaine <[email protected]> Co-authored-by: John Ky <[email protected]>
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from MarcFontaine, cleverca22, deepfire, denisshevchenko, and/or jutaro.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
bors merge |
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.