Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync percentage fixed. #3854

Merged
merged 1 commit into from
May 11, 2022
Merged

Sync percentage fixed. #3854

merged 1 commit into from
May 11, 2022

Conversation

denisshevchenko
Copy link
Contributor

Sync progress (as a part of NodeState datapoint) for cardano-tracer is fixed now.

@denisshevchenko denisshevchenko self-assigned this May 11, 2022
jutaro
jutaro requested changes May 11, 2022
View reviewed changes
Copy link
Contributor

@jutaro jutaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not: syncProgressPct :: SyncPercentage?

@denisshevchenko
Copy link
Contributor Author

@jutaro Thanks, fixed.

@denisshevchenko
Copy link
Contributor Author

bors r+

deepfire
deepfire approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

deepfire
deepfire approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 11, 2022

Already running a review

@iohk-bors
Copy link
Contributor

iohk-bors bot commented May 11, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 0e24204 into master May 11, 2022
@iohk-bors iohk-bors bot deleted the sync-progress-fix branch May 11, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire approved these changes

@jutaro jutaro jutaro approved these changes

Assignees

@denisshevchenko denisshevchenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@denisshevchenko @deepfire @jutaro