Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prop_multinode_Sim: in presence of accept IO errors #3315

Closed
coot opened this issue Sep 2, 2021 · 4 comments · Fixed by #3668
Closed

prop_multinode_Sim: in presence of accept IO errors #3315

coot opened this issue Sep 2, 2021 · 4 comments · Fixed by #3668
Assignees
@coot
Labels
inbound-governor Issues / PRs related to inbound-governor testing

Comments

@coot
Copy link
Contributor

coot commented Sep 2, 2021

This should reproduce the https://github.com/input-output-hk/cardano-node/issue/3080 problem in simulation.
@karknu
Copy link
Contributor

karknu commented Sep 2, 2021

#3289 (comment)

@coot
Copy link
Contributor Author

coot commented Sep 2, 2021

Closing as a duplicate.

@coot coot closed this as completed Sep 2, 2021
@coot coot reopened this Sep 2, 2021
@coot
Copy link
Contributor Author

coot commented Sep 2, 2021

Let's use this issue to extend the prop_multinode_Sim, #3289 is just about testing the network simulation environment.

@coot coot changed the title net-sim: inject accept IO errors prop_multinode_Sim: in presence of accept IO errors Sep 2, 2021
@coot coot added the inbound-governor Issues / PRs related to inbound-governor label Sep 20, 2021
@coot
Copy link
Contributor Author

coot commented Nov 14, 2021

See #3384, and branch coot/p2p-sim-server-error

@coot coot moved this from Todo to No Status in P2P Inbound Governor Verification Jan 11, 2022
@coot coot self-assigned this Mar 14, 2022
@coot coot moved this to In Progress in Ouroboros Network Mar 14, 2022
@coot coot mentioned this issue Mar 16, 2022
Merged
@iohk-bors iohk-bors bot closed this as completed in 818845b Mar 18, 2022
Repository owner moved this from In Progress to Done in Ouroboros Network Mar 18, 2022
Repository owner moved this from No Status to Done in P2P Inbound Governor Verification Mar 18, 2022
coot added a commit that referenced this issue May 16, 2022
@iohk-bors @coot
Merge #3668
ba57425 
3668: Enabled accept errors in net-sim testing r=coot a=coot

Fixes #3315

- ouroboros-network-framework: added todo
- sim-net: removed IOErrThrowOrReturn as an abstraction leak
- sim-net: reset channel when accept errors
- net-sim: added abiAcceptFailure
- net-sim: refactor TestError
- net-sim: fix prop_connect_to_accepting_socket
- Fixed some typos


Co-authored-by: Marcin Szamotulski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coot coot

Labels
inbound-governor Issues / PRs related to inbound-governor testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabled accept errors in net-sim testing IntersectMBO/ouroboros-network
2 participants
@coot @karknu