Refactor simplify polling on generated componenents #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor polling logic in Blazor components by introducing `ConfigurePolling` and `StartPolling` methods. Remove `DoPublishOnly` option to simplify task logic. Update `dev.yml` to include conditional logic for Cake script. Modify `build.ps1` to exit with the last exit code. Add new folders to `AXSharp.Presentation.Blazor.Controls.csproj`. Make several classes abstract to enforce proper inheritance. Update various `.razor` files to include `ConfigurePolling` and call `StartPolling`.
Simplified `UpdateValuesOnChange` methods in `RenderableComponentBase.cs` by removing the `pollingInterval` parameter. Removed `OnInitialized` method from `RenderableContentControl.razor.cs`. Improved XML documentation for `ForceRender` method. Added `PollingInterval` attribute to component initialization in `RenderableContentControl.razor.cs`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the build and polling mechanisms in the project. The most important changes involve the removal of the
DoPublishOnlyparameter and its related logic, updates to the polling mechanism in the Blazor components, and modifications to the GitHub Actions workflow.Build and Publishing Updates:
DoPublishOnlyparameter and its associated logic from theBuildParametersclass and various tasks incake/Program.cs[1] [2] [3] [4] [5] [6].Polling Mechanism Updates:
RenderableComponentBaseandRenderableComplexComponentBaseclasses to be abstract and refactored the polling methods, including the addition of aConfigurePollingmethod and renamingRemovePolledElementstoStopPolling[1] [2] [3] [4] [5] [6] [7] [8].SubscribeForPollingandUnSubscribeFromPollingmethods fromRenderableContentControl.razor.csand updated the component initialization logic to handle polling differently [1] [2] [3] [4] [5] [6].Miscellaneous Changes:
AXSharp.Presentation.Blazor.Controls.csproj).build.ps1by removing an extraneous string.launchSettings.json.