-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for text buttons #461
Conversation
With this CSS tweak it looks better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still needs some work.
Maybe some extra padding around text so they look like the icon buttons.
I personally think bold text look better but this might depend on the icon set someone is using. Maybe you can wrap the text in an element so it can be styled by developers. Standard bold text font-weight: bold
looks pretty good with the default icons in my opinion.
Longer names with separate works don't work well in dropdown menus.
Longer names with long words make the dropdown display horizontally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An empty <i>
element is created when a button is used with just text.
I think there should be some spacing left and right of the text. When combined with an icon (like you show in the README) does not look good.
What about this?
I personally think bold text look better but this might depend on the icon set someone is using. Maybe you can wrap the text in an element so it can be styled by developers. Standard bold text
font-weight: bold
looks pretty good with the default icons in my opinion.
This adds support for text in buttons and in dropdown menu.