Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path Clarity changes and dependency updates #155

Merged
merged 4 commits into from
May 21, 2020
Merged

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented May 20, 2020

I couldn't write/review any more documentation today, so I took a small tech debt issue

  • Rename/move files so we don't have to have anything named mod.rs (see attached issue for a diagram of how the new structure works)
  • Remove all extern_crate from lib.rs and instead import things directly where they're needed
  • Upgrade dependencies
    • protobuf-codegen-pure needed some changes in build.rs
    • percent-encoding needed some changes in src/internal/rest.rs. I could use a double-check on this one, so I would recommend viewing the single commit where I upgraded it to review.

@clintfred clintfred changed the title Path Clarity changes Path Clarity changes and dependency updates May 21, 2020
Copy link
Contributor

@clintfred clintfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this warrants a "Notable Internal Changes" changelog entry, but maybe...

Cargo.toml Show resolved Hide resolved
src/internal/rest.rs Show resolved Hide resolved
@giarc3 giarc3 merged commit 35f4dff into master May 21, 2020
@giarc3 giarc3 deleted the 103-path-clarity branch May 21, 2020 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants