[#44] Adds user private key rotation #59

clintfred · 2019-10-22T22:31:22Z

TODO

resolve issue with generating devices after user private key rotation

Changelog

Adds method UserOps::user_rotate_private_key
Adds a new initialization option: ironoxide::initialize_check_rotation to enable users to know if any of their private keys need rotation.

* first pass on initialization interface * private key augmentation working and tested * blocked on ability to get encrypted user master private key back from the service

…-rotate # Conflicts: # src/internal/mod.rs # src/lib.rs # tests/common/mod.rs

* local user private key augmentation working * use new get private key endpoint to get user encrypted private key

…-rotate # Conflicts: # tests/common/mod.rs

* WIP basic user private key rotation in place

…te key rotation

…r.rs

giarc3 · 2019-10-23T16:18:29Z

I pushed a commit that put UserUpdatePrivateKeyResult and EncryptedPrivateKey into the pub use crate section of user.rs so that I could access them in ironoxide-java. Let me know if there's a reason we shouldn't do this and I'll change it back.

src/internal/mod.rs

src/internal/user_api/mod.rs

src/lib.rs

* adds internal retry for augmentation factor generation

src/internal/mod.rs

src/internal/rest.rs

src/internal/user_api/mod.rs

src/lib.rs

tests/user_ops.rs

… 44-user-private-key-rotate

coltfred

Couple small things I'd prefer, but I wouldn't hold it up.

src/lib.rs

coltfred

Note that the release shouldn't be published until the service changes have been rolled out. We can merge to master, though.

src/internal/mod.rs

src/internal/user_api/requests.rs

clintfred added 12 commits September 26, 2019 16:08

[#44]

c8eac02

* first pass on initialization interface * private key augmentation working and tested * blocked on ability to get encrypted user master private key back from the service

Merge remote-tracking branch 'origin/master' into 44-user-private-key…

f5e2a1a

…-rotate # Conflicts: # src/internal/mod.rs # src/lib.rs # tests/common/mod.rs

[#44] back to compiling after merge

aba6075

[#44]

290c4e9

* local user private key augmentation working * use new get private key endpoint to get user encrypted private key

Merge remote-tracking branch 'origin/master' into 44-user-private-key…

a870e5e

…-rotate # Conflicts: # tests/common/mod.rs

[#44]

ed131d1

* WIP basic user private key rotation in place

[#44] better user private key rotation with an integration test

67556a5

[#44] WIP sdk initialization with user needs_rotation

c733618

[#44] WIP decrypt with rotated private key is failing

9578bcd

[#44] adds a test that adds a new device for a user after doing priva…

97493bc

…te key rotation

[#44] removes some TODOs and logs the body of requests for inspection

7125c3c

[#44] adds documentation; preparing for PR

dbf7312

clintfred changed the title ~~44 user private key rotate~~ [#44] Adds User private key rotation Oct 22, 2019

clintfred changed the title ~~[#44] Adds User private key rotation~~ [#44] Adds user private key rotation Oct 22, 2019

Made UserUpdatePrivateKeyResult and EncryptedPrivateKey public in use…

b9b0305

…r.rs

Merge branch 'master' into 44-user-private-key-rotate

fe37721

BobWall23 requested changes Oct 24, 2019

View reviewed changes

src/internal/mod.rs Outdated Show resolved Hide resolved

src/internal/mod.rs Outdated Show resolved Hide resolved

src/internal/mod.rs Outdated Show resolved Hide resolved

src/internal/user_api/mod.rs Outdated Show resolved Hide resolved

src/lib.rs Show resolved Hide resolved

coltfred and others added 3 commits October 25, 2019 11:21

Bump to branch recrypt and fix other test

0e37236

[#44] addresses PR feedback

f80cb66

* adds internal retry for augmentation factor generation

Bump to stable recrypt-rs

8ac307d

coltfred requested changes Oct 28, 2019

View reviewed changes

clintfred added 4 commits October 28, 2019 11:08

[#44] removes a few println and dbg statements

02d503e

[#44] addresses several PR comments

d4cc9e8

Merge remote-tracking branch 'origin/44-user-private-key-rotate' into…

0f65591

… 44-user-private-key-rotate

[#44] removes an unnecessary PrivateKey clone

12d3e99

coltfred approved these changes Oct 28, 2019

View reviewed changes

src/lib.rs Outdated Show resolved Hide resolved

[#44] renames a couple of functions based on reviewer's comments

a0a022f

coltfred approved these changes Oct 29, 2019

View reviewed changes

BobWall23 requested changes Oct 29, 2019

View reviewed changes

src/internal/mod.rs Show resolved Hide resolved

src/internal/user_api/requests.rs Show resolved Hide resolved

clintfred added 3 commits October 29, 2019 11:40

[#44] bumps version to 0.13.0

2b202b4

[#44] removes current_key_id from public API

e66e78f

[#44] improves flow of private key augmentation

9f5c7e3

BobWall23 approved these changes Oct 29, 2019

View reviewed changes

clintfred merged commit eb6b7e7 into master Oct 30, 2019

clintfred deleted the 44-user-private-key-rotate branch October 30, 2019 14:43

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#44] Adds user private key rotation #59

[#44] Adds user private key rotation #59

clintfred commented Oct 22, 2019 •

edited

Loading

giarc3 commented Oct 23, 2019

coltfred left a comment

coltfred left a comment

[#44] Adds user private key rotation #59

[#44] Adds user private key rotation #59

Conversation

clintfred commented Oct 22, 2019 • edited Loading

TODO

Changelog

giarc3 commented Oct 23, 2019

coltfred left a comment

Choose a reason for hiding this comment

coltfred left a comment

Choose a reason for hiding this comment

clintfred commented Oct 22, 2019 •

edited

Loading