Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make test environment configurable #69

Merged
merged 18 commits into from
Nov 6, 2019
Merged

Make test environment configurable #69

merged 18 commits into from
Nov 6, 2019

Conversation

giarc3
Copy link
Member

@giarc3 giarc3 commented Nov 5, 2019 •
edited
Loading

TODO:

  • Update the CHANGELOG.md
  • Update the documentation for the latest design changes
  • Verify that Travis is decrypting successfully

@giarc3 giarc3 marked this pull request as ready for review November 5, 2019 22:35
coltfred
coltfred requested changes Nov 6, 2019
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple wording changes and we need to discuss the default cargo test env.

tests/INTEGRATION-TESTS.md Outdated Show resolved Hide resolved
tests/INTEGRATION-TESTS.md Outdated Show resolved Hide resolved
tests/INTEGRATION-TESTS.md Outdated Show resolved Hide resolved
clintfred
clintfred approved these changes Nov 6, 2019
View reviewed changes
Copy link
Contributor

@clintfred clintfred left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Don't forget a change log entry.

@giarc3 giarc3 changed the title Make test environment variable Make test environment configurable Nov 6, 2019
@giarc3 giarc3 merged commit dbee6f7 into master Nov 6, 2019
@giarc3 giarc3 deleted the 54-portable-tests branch November 6, 2019 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltfred coltfred coltfred approved these changes

@clintfred clintfred clintfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@giarc3 @coltfred @clintfred