Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#84] Reuse tokio runtime for device auth'd SDK calls #91

Merged
merged 4 commits into from
Dec 6, 2019
Merged

[#84] Reuse tokio runtime for device auth'd SDK calls #91

merged 4 commits into from
Dec 6, 2019

Conversation

clintfred
Copy link
Contributor

@clintfred clintfred commented Dec 5, 2019 •
edited
Loading

see #84

TODO

  • changelog entry

coltfred
coltfred requested changes Dec 6, 2019
View reviewed changes
Copy link
Member

@coltfred coltfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to comment about the runtime when we create it, but other than that this looks good.

src/lib.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@coltfred
Copy link
Member

coltfred commented Dec 6, 2019

Don't forget the changelog entry.

@clintfred clintfred merged commit d8b7f95 into master Dec 6, 2019
@clintfred clintfred deleted the 84-reuse-tokio-rt branch December 6, 2019 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coltfred coltfred coltfred approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clintfred @coltfred