Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Quality: Update source to show .NET Foundation copyright #1813

Merged
merged 3 commits into from
Nov 27, 2024

Conversation

Lamparter
Copy link
Contributor

Hi there (again)!
I noticed that the .NET Foundation copyright was missing from some source files and instead showed "IronPython Team", which isn't the official licenseholder specified in the LICENSE file in the root directory.
This is a small fix to change that to the .NET Foundation.

@slozier
Copy link
Contributor

slozier commented Nov 17, 2024

Thanks for the PR. I think this is fine although I try to avoid touching any licensing/copyright related stuff. @slide any chance you would remember the details regarding copyright when you did the onboarding with the .NET Foundation?

@slide
Copy link
Contributor

slide commented Nov 17, 2024

I don't remember, sorry!

@Lamparter
Copy link
Contributor Author

image

Submit a project | .NET Foundation

I'm going to imagine that IronPython would have been entered into the .NET Foundation under the Assignment model.

@slozier
Copy link
Contributor

slozier commented Nov 19, 2024

I'm going to imagine that IronPython would have been entered into the .NET Foundation under the Assignment model.

Yes, that's what I'm assuming as well but doesn't hurt to check.

@Lamparter
Copy link
Contributor Author

Their website doesn't really display too much information about the project dotnetfoundation.org/projects/project-detail/DLR-IronPython2-IronPython3
There isn't really a place to ask for this sort of thing.

@Lamparter
Copy link
Contributor Author

Regardless, the actual license states that the copyright holder is the .NET Foundation. @slozier would you mind reviewing this when you get a chance?

@slozier slozier merged commit b48e24b into IronLanguages:main Nov 27, 2024
2 of 8 checks passed
@Lamparter Lamparter deleted the dotnet-copyright branch November 27, 2024 15:32
Lamparter added a commit to Lamparter/IronPython that referenced this pull request Nov 28, 2024
in places i must have missed in IronLanguages#1813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants