Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of ArrayUtils.EmptyObjects #1820

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Conversation

slozier
Copy link
Contributor

@slozier slozier commented Nov 29, 2024

Gets rid of uses of ArrayUtils.EmptyObjects and ArrayUtils.EmptyStrings. Uses the C# 12 empty collection expression [] as a replacement. Ultimate goal is to try and remove dependencies on DLR utils (like ArrayUtils) so they can be obsoleted (less code to worry about).

Copy link
Member

@BCSharp BCSharp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this all or is there more to come?

@slozier
Copy link
Contributor Author

slozier commented Nov 29, 2024

Is this all or is there more to come?

It's all for now. I looked at more of the ArrayUtils usage an there didn't seem to be clear cut replacements (unless there are some array manipulation APIs I'm missing in the core libraries). Thinking that making an internal copy and flagging the DLR class as obsolete might be a good way to proceed...

@slozier slozier merged commit e970303 into IronLanguages:main Nov 29, 2024
8 checks passed
@slozier slozier deleted the arrayutils branch November 29, 2024 13:56
@Lamparter
Copy link
Contributor

Glad to see more activity now 😄
When the "infrastructure tsunami" as @BCSharp calls it gets pushed through there'll be far more activity from my side 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants