Fix: Asset uploads fail if >30 assets #1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I happened to just make pretty much the same change lol. I've merged the best from our both commits. 🎉 |
|
lol wrong button, now merged 🎉 |
|
Thanks for being open to suggestions / fixes! really appreciate it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here: #1 (comment).
This should be all okay. I've already tested change this on my own workflow and it all went though successfully to create this release.
The only potential issue for me is that GH limits you to 1000 API requests per hour, which I might be running into if I'm not careful (although that's a completely different issue).