Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stupid mac tricks: Sed has different syntax on a mac and should be replaced with Perl #116

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Stupid mac tricks: Sed has different syntax on a mac and should be replaced with Perl #116

merged 3 commits into from
Oct 7, 2020

Conversation

noahwsmith
Copy link
Contributor

Addresses #115 - fixes sed for mac. Tested on linux and it still works fine over there, and on mac to ensure make dev completes.

@noahwsmith
Copy link
Contributor Author

Ok, I've moved it to Perl from Sed. @dannylamb check me that I'm doing what you intended? I think I got it all working properly.

@noahwsmith noahwsmith changed the title Stupid mac tricks: Sed requires extension (empty) Stupid mac tricks: Sed has different syntax on a mac and should be replaced with Perl Oct 6, 2020
birkland
birkland previously requested changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@birkland birkland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not at my machine right now, but I believe Perl would need to be installed explicitly if building on Windows in some circumstances. So could you add Perl to the list of requirements in the README too?

@noahwsmith
Copy link
Contributor Author

@birkland I make a small change to the Readme to address your request

@birkland birkland self-requested a review October 7, 2020 15:16
@birkland birkland dismissed their stale review October 7, 2020 15:17

perl added to README

seth-shaw-unlv
seth-shaw-unlv approved these changes Oct 7, 2020
View reviewed changes
Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised on my iMac.

@seth-shaw-unlv
Copy link

Anyone else want to give it a try before we merge this?

@rosiel
Copy link
Contributor

rosiel commented Oct 7, 2020

I'm running it now... :D so far so good

rosiel
rosiel approved these changes Oct 7, 2020
View reviewed changes
Copy link
Contributor

@rosiel rosiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! this worked!

@rosiel rosiel merged commit 89bcc2f into development Oct 7, 2020
@rosiel rosiel mentioned this pull request Oct 8, 2020
Merged
7 tasks
@dannylamb dannylamb deleted the mac-patch-sed branch February 16, 2021 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seth-shaw-unlv seth-shaw-unlv seth-shaw-unlv approved these changes

@rosiel rosiel rosiel approved these changes

@dannylamb dannylamb Awaiting requested review from dannylamb

@birkland birkland Awaiting requested review from birkland

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noahwsmith @seth-shaw-unlv @rosiel @birkland