Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #77

Merged
merged 5 commits into from
May 5, 2021
Merged

Conversation

elizoller
Copy link
Member

@elizoller elizoller commented May 3, 2021

GitHub Issue: (Islandora/documentation#1798)

What does this Pull Request do?

Converts to github actions
updates the badges
removes travis

What's new?

  • new CI runner

How should this be tested?

  • make sure the tests pass (i don't think they will until this PR is merged - but you can see them running over on the branch itself)

Build completion proof here: https://github.com/asulibraries/Alpaca/runs/2479719378?check_suite_focus=true
Codecov proof here: https://codecov.io/gh/asulibraries/Alpaca/commit/35408a19672689883ecbe47a05827dc3583384db

Notes

I am not sure what this section does: https://github.com/Islandora/Alpaca/blob/dev/.travis.yml#L24 so i don't know if i have to replicate this

Interested parties

@Islandora/8-x-committers

@seth-shaw-unlv
Copy link
Contributor

Well, I don't know GitHub actions, but the essence of those lines is that after everything passes we use the gradlew command to push a build up to the Nexus Repository Manager (https://oss.sonatype.org). The key is how we store those username/password variables currently in Travis in GitHub Actions.

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the discussion in Slack w/ @dannylamb and @ruebot, let's :shipit: .

@seth-shaw-unlv seth-shaw-unlv merged commit 07d1459 into Islandora:dev May 5, 2021
@seth-shaw-unlv
Copy link
Contributor

Note: we won't really know if the uploadArchives works until we merge into main.

emetsger pushed a commit to jhu-idc/Alpaca that referenced this pull request Jun 8, 2021
emetsger pushed a commit to jhu-idc/Alpaca that referenced this pull request Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants