-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix undefined prefixes #60
Conversation
Codecov Report
@@ Coverage Diff @@
## master #60 +/- ##
============================================
+ Coverage 97.1% 97.13% +0.03%
- Complexity 140 146 +6
============================================
Files 9 9
Lines 621 629 +8
============================================
+ Hits 603 611 +8
Misses 18 18
Continue to review full report at Codecov.
|
Spinning up a base box right now, but can test this soon @whikloj. Thx for the documentation, too. |
Taking my name off this one since I'm super busy for the next week or so. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, ansible-role-crayfish's template for Recast needs to be updated to include the common prefixes (see the new example config) before anyone will notice the improvement... |
GitHub Issue: n/a Follow of on #44
This PR fixes the issue identified by @dannylamb in this comment
What does this Pull Request do?
Items with prefix mappings unknown to EasyRdf end up with default prefixes (ns0, ns1, ns2, etc)
This allows a user to add prefix/URI mappings to the recast service and have them appear.
What's new?
How should this be tested?
Prior to this PR any resource transformed would get anonymous prefixes for things in the
http://fedora.info/definitions/v4/repository#
andhttp://pcdm.org/models#
namespace URIs.After this PR, they will appear as
fedora:
andpcdm:
though this is configurable.Additional Notes:
Interested parties
@Islandora-CLAW/committers