Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix undefined prefixes #60

Merged
merged 4 commits into from
Apr 29, 2019
Merged

Conversation

whikloj
Copy link
Member

@whikloj whikloj commented Mar 25, 2019

GitHub Issue: n/a Follow of on #44

This PR fixes the issue identified by @dannylamb in this comment

What does this Pull Request do?

Items with prefix mappings unknown to EasyRdf end up with default prefixes (ns0, ns1, ns2, etc)

This allows a user to add prefix/URI mappings to the recast service and have them appear.

What's new?

  • Does this change require documentation to be updated? yes, included
  • Does this change add any new dependencies? no
  • Does this change require any other modifications to be made to the repository (ie. Regeneration activity, etc.)? no
  • Could this change impact execution of existing code? no

How should this be tested?

Prior to this PR any resource transformed would get anonymous prefixes for things in the http://fedora.info/definitions/v4/repository# and http://pcdm.org/models# namespace URIs.

After this PR, they will appear as fedora: and pcdm: though this is configurable.

Additional Notes:

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Mar 25, 2019

Codecov Report

Merging #60 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #60      +/-   ##
============================================
+ Coverage      97.1%   97.13%   +0.03%     
- Complexity      140      146       +6     
============================================
  Files             9        9              
  Lines           621      629       +8     
============================================
+ Hits            603      611       +8     
  Misses           18       18
Impacted Files Coverage Δ Complexity Δ
Recast/src/Controller/RecastController.php 82.65% <100%> (+1.54%) 30 <0> (+6) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be5bb9a...e730ef4. Read the comment docs.

@dannylamb
Copy link
Contributor

Spinning up a base box right now, but can test this soon @whikloj.

Thx for the documentation, too.

@dannylamb
Copy link
Contributor

Taking my name off this one since I'm super busy for the next week or so. :(

Copy link
Contributor

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@seth-shaw-unlv
Copy link
Contributor

Although, ansible-role-crayfish's template for Recast needs to be updated to include the common prefixes (see the new example config) before anyone will notice the improvement...

@seth-shaw-unlv seth-shaw-unlv merged commit 0b49f10 into Islandora:master Apr 29, 2019
@whikloj whikloj deleted the recast-prefixes branch April 29, 2019 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants