Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Homarus to generate PNG audio thumbnails #78

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

kayakr
Copy link
Contributor

@kayakr kayakr commented Oct 11, 2019

GitHub Issue: Islandora/documentation#1298

What does this Pull Request do?

Allow Homarus to generate PNG audio thumbnails by adding image/png as allowable request content type and image/png_image2pipe as output target.

What's new?

Homarus can generate jpeg thumbnails. This allows PNG thumbnails, as specified for thumbnailing of audio files.

How should this be tested?

  • Apply this config to Homarus: /var/www/html/Crayfish/Homarus/cfg/config.yaml
  • Add 'Audio - Generate a thumbnail from an original file' action from Use-a-Thon: Waveform thumbnails for audio files documentation#1298
  • Create a repository item with model=Audio, and Audio media with Use=Original file and upload a .mp3 or .wav file.
  • In Content administration, check the checkbox for the audio item, then select the action 'Audio - Generate a thumbnail from an original file' and click 'Apply to selected items' button.
  • Check the Media tab for the audio repository item, you should see a new media with Use=Thumbnail Image with a related PNG file representing the waveform (black waveform on white background).

Interested parties

@Islandora-CLAW/committers

@codecov
Copy link

codecov bot commented Oct 11, 2019

Codecov Report

Merging #78 into dev will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                dev      #78   +/-   ##
=========================================
  Coverage     94.64%   94.64%           
  Complexity      160      160           
=========================================
  Files             9        9           
  Lines           654      654           
=========================================
  Hits            619      619           
  Misses           35       35

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4173b13...710b7a8. Read the comment docs.

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@dannylamb dannylamb merged commit d41371b into dev Oct 18, 2019
@dannylamb dannylamb deleted the homarus-png-thumbnails branch January 29, 2020 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants