Updates for PHP 7.4 and Composer 2. #89
Conversation
- Update to require PHP 7.4 - Update easyrdf to v1+ - Update php_codesniffer to v3+ - Update phpunit to v9+ - Update phpcpd to v6+ - Update tests to work with newer version of phpunit - Update EasyRdf namespaces since they use proper namespaces with 1.0.0 - Update README
installed versions of phpunit, etc.
|
I think the default branch needs to be updated on CodeCov for this repo from master to main: https://app.codecov.io/gh/Islandora/chullo/settings |
|
@ruebot Any chance we can cover 7.3 and 7.4 here? I'm hesitant to jump straight to 7.4 here if we don't have to. |
|
Oh, I see now: https://travis-ci.org/github/Islandora-Devops/ansible-role-crayfish/jobs/748458293#L761 💩, no choice then. |
|
I updated the codecov settings to make |
|
I'm going to change the coverage filename back to what it was previously. |
|
🤷♂️ https://travis-ci.com/github/Islandora/chullo/builds/207818467#L355 No idea what's the deal there. I'm not super concerned about it if y'all aren't. |
|
Just to second the question about PHP 7.3 support. I have been out of the loop but did we stop supporting it? |
|
@whikloj hey Jared! It's a Composer 2 issue from what I understand, and was partially implemented in the playbook and in Crayfish. From my digging in further of the last couple days to resolve a TravisCI problem on this PR, things escalated very quickly 😓, and I'm just trying to finish the job to my current understanding. That said, not sure what the community policies are on updating PHP versions, so if that's the concern, it's completely valid. Though, I leave it up to y'all on how to proceed. |
|
Thanks all (and hi Nick 👋 ), I guess this answers my question. |
|
FWIW ISLE is already on php 7.4, which is why i never noticed it when moving everything over to composer 2 for it |
|
IMO we can just fix codecov later. I'd rather move on, since this is blocking some sprint things. Let's just be sure to advertise this change when releasing. Sounds like the kinda thing that warrants a changelog entry. |
|
so what does this need? someone to pull it in, composer install, and make sure chullo still works? |
There was a problem hiding this comment.
I can't speak to the code-cov piece but this is what I did to test:
i have a d9 box (built from that islandora-playbook PR #196), i went into /var/www/html/drupal/vendora/islandora/chullo and checked out pull/89 and then ran composer install in there and then i went to islandora and made an item and verified it made it to fedora.
|
CodeCov bit will hopefully work itself out after a merge 🤞 |
GitHub Issue:
What does this Pull Request do?
Updates for PHP 7.4 and Composer 2.
How should this be tested?
Additional Notes:
I'm fairly certain I'll need this for: Islandora/Crayfish#110
Interested parties
@rosiel @seth-shaw-unlv @dannylamb