Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request do?
Allows for a confirmation screen for the 'Delete media and files' action. Also reworks the action a little to be more in line with other entity delete actions.
What's new?
/media/delete_with_files
, which acts as a confirmation form for bulk deleting media with associated files and translations. This route doesn't accept parameters; rather, it relies on themedia_and_file_delete_confirm
temporary storage for the current user to know what was checked off.How should this be tested?
With Islandora enabled:
/admin/content/media/
Additional Notes:
This represents something of a departure from the existing action in that the
execute()
action no longer immediately deletes the given entities. This doesn't appear to be run anywhere programmatically in the codebase, but it's worth mentioning in case someone somewhere is trying to run this programmatically.Interested parties
@Islandora/8-x-committers