Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IslandoraFunctionalTestBase.php #799

Closed
wants to merge 2 commits into from

Conversation

dannylamb
Copy link

Github Issue: Discovered on #797

What does this Pull Request do?

Fixes tests so Travis passes.

What's new?

Manually enabling menu_link_content in our Functional tests.

How should this be tested?

Travis should be appeased

Additional Notes:

Dunno why this popped on us now 🤷‍♂️

Interested parties

@Islandora/8-x-committers

@seth-shaw-unlv
Copy link

Travis, travis, travis.... haven't we gone through this time out business before??

@dannylamb
Copy link
Author

Ugh... we're literally at the point where we'll need to refactor just to put the tests in other repos so we can survive Travis's timeout limits.... Not entirely sure how best to proceed at this point.

@rosiel
Copy link
Member

rosiel commented Oct 13, 2020

Can we discuss/work on this at the Oct 14 Tech Call?

@dannylamb
Copy link
Author

Yes please. Feel free to add it to the agenda: https://github.com/Islandora/documentation/wiki/October-14%2C-2020

@rosiel rosiel mentioned this pull request Oct 21, 2020
@rosiel
Copy link
Member

rosiel commented Oct 22, 2020

Done with #805

@rosiel rosiel closed this Oct 22, 2020
@seth-shaw-unlv seth-shaw-unlv deleted the fix-travis-menu-link-content branch September 1, 2021 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants