Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename multifile media ocr derivative type. #875

Merged
merged 3 commits into from
Jun 1, 2022

Conversation

rosiel
Copy link
Member

@rosiel rosiel commented May 25, 2022

GitHub Issue: (none)

What does this Pull Request do?

I am documenting how derivatives work as Drupal actions. The fact that we had two derivatives types, "Generate an extracted text derivative file" and "generate OCR from image" was concerning.

They do the same thing, but one was multi=file media. The other MFM derivative types use "for media attachment" in their names so that's what I did here.

What's new?

  • Changed the display name of the MFM OCR derivative type.

  • Does this change add any new dependencies? np

  • Does this change require any other modifications to be made to the repository np
    (i.e. Regeneration activity, etc.)?

  • Could this change impact execution of existing code? np

How should this be tested?

With this PR, does the list of derivative options make sense?

Documentation Status

  • Does this change existing behaviour that's currently documented? unlikely that it's documented
  • Does this change require new pages or sections of documentation? yes, i'm working on them
  • Who does this need to be documented for? repository admins who need to know how derivatives work
  • Associated documentation pull request(s): ___ or documentation issue ___

Additional Notes:

Any additional information that you think would be helpful when reviewing this
PR.

Interested parties

Tag (@ mention) interested parties or, if unsure, @Islandora/8-x-committers

@DonRichards DonRichards self-requested a review May 25, 2022 18:14
@DonRichards
Copy link
Member

Double approved!

Copy link

@seth-shaw-unlv seth-shaw-unlv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@seth-shaw-unlv seth-shaw-unlv merged commit 222c960 into Islandora:2.x Jun 1, 2022
@rosiel rosiel deleted the ocr-rename branch November 25, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants