Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove width to make it responsive #9

Merged
merged 1 commit into from
May 15, 2019
Merged

Remove width to make it responsive #9

merged 1 commit into from
May 15, 2019

Conversation

seth-shaw-unlv
Copy link
Contributor

GitHub Issue: Islandora/documentation/issues/1105

What does this Pull Request do?

Removes the openseadragon-viewer width setting (600px) to make it more responsive.

What's new?

  • Removed the openseadragon-viewer width setting (was 600px, now defaults to 100%).
  • Does this change require documentation to be updated? No.
  • Does this change add any new dependencies? No.
  • Does this change require any other modifications to be made to the repository
    (ie. Regeneration activity, etc.)? No.
  • Could this change impact execution of existing code? No.

How should this be tested?

  • Make an item
  • Use the Open Seadragon display helper
  • squeeze your window narrow and see the window remain 600px wide
  • Apply the PR
  • Flush caches
  • View the item again and the viewer should adjust as you change your browser window width

Interested parties

@Natkeeran, @whikloj, @dannylamb

Copy link
Contributor

@dannylamb dannylamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised :shipit:

@dannylamb dannylamb merged commit d4d950c into Islandora:8.x-1.x May 15, 2019
@seth-shaw-unlv seth-shaw-unlv deleted the issue-1105 branch May 23, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants